Subplot margins (Chapter 1, Exercise 2)

[labdmitriy]

Hi @rougier,

There is a statement about additional figure margins for Exercise 2 solution:

scientific-visualization-book/code/anatomy/inch-cm.py

Lines 13 to 15 in a6e0607

	# However, we need to have margins in our figure (or tick labels will be cut)
	# so we'll have 0.25 inches margin on each side of the axis such that the axis
	# will be 4 inches.

And there is a code that performs this adjustment:

scientific-visualization-book/code/anatomy/inch-cm.py

Lines 27 to 38 in a6e0607

	inch = 2.54
	fig_width = 10.8 / inch # ~4.252 inches
	fig_height = 1.25 # 1.250 inches
	margin = 0.125 # 0.125 inches
	fig = plt.figure(figsize=(fig_width, fig_height))
	plt.subplots_adjust(
	left=0.5 * margin / fig_width,
	right=1 - 0.5 * margin / fig_width,
	bottom=0.5 * margin / fig_height,
	top=1 - 0.5 * margin / fig_height,
	)

It seems that in this case we need to have 0.125 inches margin on each side (not 0.25 as in the description), and margin=0.25 (not 0.125 as in the code) because we multiply this margin by 0.5 when we call plt.subplots_adjust().
Is it correct?

Thank you.

[rougier]

You're right. We need 0.125 margin on each side and the 0.5* is confusing (and wrong). Figure in the book seems to be the right size but probably the difference is not noticeable. Can you make a PR?