Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM-Devices support #122

Closed
dockerpirate opened this issue Dec 29, 2020 · 25 comments
Closed

Add ARM-Devices support #122

dockerpirate opened this issue Dec 29, 2020 · 25 comments

Comments

@dockerpirate
Copy link

dockerpirate commented Dec 29, 2020

Please add arm-devices support (e.g. armv7, armv8), it works easy with docker buildx

https://docs.docker.com/docker-for-mac/multi-arch/

@amiga23
Copy link

amiga23 commented Feb 3, 2021

Can not build it on aarch64 (apache/Dockerfile), do get the following error message and have no glue what that should mean:

+ docker-php-ext-configure gd --with-freetype-dir=/usr/include/ --with-png-dir=/usr --with-jpeg-dir=/usr
fetch https://dl-cdn.alpinelinux.org/alpine/edge/main/aarch64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/edge/community/aarch64/APKINDEX.tar.gz
ERROR: unsatisfiable constraints:
  pkg-config (missing):
    required by: .phpize-deps-configure-20210203.181158[pkg-config]
error building image: error building stage: failed to execute command: waiting for process to exit: exit status 2

@dockerpirate
Copy link
Author

Alpine is very specific, it could be, that some packages are missing or have different names, or other odd issues

@jdavidbakr
Copy link

Any chance this is going to get an arm64 docker image soon? I'm wanting to deploy this into my AWS ECS environment but it's failing because it's running in the arm64 architecture.

@thomascube
Copy link
Member

@jdavidbakr I'm afraid not. We'd welcome pull requests for this but we're not actively develop an arm branch at this time.

@williamdes
Copy link
Contributor

I can work on this, are contributions welcome to make the roundcube image work for as much archs as possible ?

I would of course use docker buildx, see examples in: https://github.com/sudo-bot/nut-upsd

@thomascube
Copy link
Member

@williamdes Yes, contributions are very welcome. So far we're building the images directly on Docker Hub via Webhooks. We should check whether that's still possible for other archs, too.

@williamdes
Copy link
Contributor

@williamdes Yes, contributions are very welcome. So far we're building the images directly on Docker Hub via Webhooks. We should check whether that's still possible for other archs, too.

Well I think this will not be possible but the easy alternative is to make the webhooks trigger a workflow in this repository that will launch the build
And even easier if you push a tag for each version on this repository the workflow would just have to wait for events on tags.

Let me know what you prefer

Docker buildx does not work with Docker Hub as far as I know
But GitHub actions does the job perfectly to build images and push them !

@thomascube
Copy link
Member

Docker buildx does not work with Docker Hub as far as I know
But GitHub actions does the job perfectly to build images and push them !

That's fair enough. I think we can go with this. Let's first get the Dockerfiles right and then see how we can best automate the builds. Thanks a lot for your efforts!

@williamdes
Copy link
Contributor

Hi there,
As one of the users of Docker Hub’s Autobuild service, we wanted to reach out and let you know that from June 18th, 2021 users on the free plan will no longer have access to the Autobuild feature. This means that any of your currently configured Autobuild will fail to run and you will need to upgrade to a Pro or Team account to restore functionality. You can read more about the changes on our blog.

I received this from Docker hub
I suppose this will be a good occasion to fix two problems in one time

@thomascube
Copy link
Member

@williamdes yes, i saw that announcement too. We will, however, apply for the open source program but in parallel I’ll also read into Github’sDocker services.

@williamdes
Copy link
Contributor

@williamdes yes, i saw that announcement too. We will, however, apply for the open source program but in parallel I’ll also read into Github’sDocker services.

I will be contributing soon to fix this arm problem :)

I just deployed my Docker Mailserver replica on my RaspberryPi

@AlexanderZhirov
Copy link

I just deployed my Docker Mailserver replica on my RaspberryPi

Me too. Roundcube is very necessary

@williamdes
Copy link
Contributor

williamdes commented Aug 17, 2021

Starting to work on it

will update this summary:

@williamdes
Copy link
Contributor

Hi @J0WI
I have re-worked the process in #141

Seeing the monstrous time it takes to build multi arch: https://github.com/williamdes/roundcubemail-docker/actions/runs/1144445590
I would consider making Roundcube apply to the Docker official repository program that would allow cost-less multi arch builds in the end

@Etruscian
Copy link

What is the current state of the arm image? I don't have a lot of docker image build knowledge, but if I can help, please do tell! :)

@seb-daehne
Copy link

Hey,

it looks like GitHub Actions are now used on mainline - is the plan to add the arm build or do you intend to stay on dockerhub builds?

I believe there you can also build for arm.

@williamdes
Copy link
Contributor

Hi @J0WI
Would you mind helping roundcube have a docker official image ?

@J0WI
Copy link
Contributor

J0WI commented Mar 2, 2022

Sure, see #31

@azoller1
Copy link

azoller1 commented Jun 10, 2022

For anyone wanting to build for arm/arm64, it is very easy. Just clone the repo and choose a version/directory and build from the dockerfile. I built directly on my pi 4 with buildx.

Install the buildx alias first
docker buildx install

Then just run the docker build command (fpm one worked for me)
docker build -f Dockerfile . -t user/roundcube:version

@ZsBT
Copy link

ZsBT commented Nov 24, 2022

Github does support buildx. I already use it to make multi-arch images with this action: https://github.com/ZsBT/haproxy-quic/blob/main/.github/workflows/docker-image.yml
I've built an image on my arm server using the official Roundcube Dockerfile and works like a charm.

I'd be happy to help if you accept PRs.

@williamdes
Copy link
Contributor

Github does support buildx. I already use it to make multi-arch images with this action: https://github.com/ZsBT/haproxy-quic/blob/main/.github/workflows/docker-image.yml I've built an image on my arm server using the official Roundcube Dockerfile and works like a charm.

I'd be happy to help if you accept PRs.

I think you can open a PR using buildx
Until this image eventually gets to official images

@ZsBT
Copy link

ZsBT commented Nov 24, 2022

PR #200 sent, workflow awaiting approval

@williamdes
Copy link
Contributor

Implemented in #201
And pushed to the hub, so /closed?

@ZsBT
Copy link

ZsBT commented Feb 3, 2023

I've just tested on both 64-bit and 32-bit arm systems, the containers start properly.

@williamdes
Copy link
Contributor

Hi @dockerpirate
Can you close this issue ?

@pabzm pabzm closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests