Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Scaling #3

Closed
vonruti opened this issue Nov 25, 2018 · 1 comment
Closed

Feature Scaling #3

vonruti opened this issue Nov 25, 2018 · 1 comment

Comments

@vonruti
Copy link

vonruti commented Nov 25, 2018

Could you add in the documentation if preprocessing such as feature scaling is necessary. As far as I understand you should not scale the features as otherwise the + and - operator for the physical feature construction does not make sense anymore. This is something I think is missing in the SISSO paper and would be useful to have in a documentation.
@rouyang2017
Copy link
Owner

Sorry for this confusion! Yes, you are right. SISSO does not do any feature scaling or normalisation to your input primary features for feature construction! It is only after feature construction, then features are standardized for the SIS step for the feature selection purpose only!. We will mention this in a coming SISSO-related paper! Thank you.

@vonruti vonruti closed this as completed Nov 28, 2018
@jungsdao jungsdao mentioned this issue Dec 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rouyang2017 @vonruti