-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popup windows cause crash due to deleting the controllers #11
Comments
This seems to be the Right Way to refactor issue #11, and just needs to be applied to the rest of the sheets/popups
|
This is infrastructure working toward a resolution for #11
For issue #11, this will become a base class for all the modal sheets that show over the repo window.
…dalRepoSheet objects This is more lead-up for issue #11
This is a test case for the proper fix for issue #11
This should be significantly more stable, but may have broken some functionality. Needs further primary testing to verify. Continuing work on issue #11
This should now only need testing for cases that aren't based on the common subclasses. It's a lot of fiddly UI testing work, but I'd sure appreciate the help. |
Probably resolved, but needs thorough UI testing including failures and error messages. Seems this is the only outstanding issue that I've slated for 1.0... scary thought, will prioritise some more issues tomorrow. |
Clone repo dialog w/
|
Create a branch with an existing branch name as a folder prefix: error message demonstrates this behaviour. i.e. |
Working on resolving crash when using the built-in clone tools. With this fix, a git repo can be successfully cloned, but does not close the clone window. Work relates mostly to issue #11 - window and controller memory management.
It seems NSURLs cannot be used in property lists, which caused this specific problem. NSPasteboard also provides a »writeObjects:« method now which is made exactly for this use case.
i.e. create tag dialog
Need to implement a good, app-wide solution here. Current workaround is to keep all controllers around indefinitely. App/document should own the controllers for their duration.
The text was updated successfully, but these errors were encountered: