Open email webview #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mfmurray
commented
Oct 31, 2022
mfmurray
commented
- Added logic to listen to url from webview and check if url is "mailto" to then open default email inbox
- Added constant for Feature Flags
mhamann
reviewed
Nov 3, 2022
| let encodedData = try encoder.encode(frameworkFeatures) | ||
| return String(data: encodedData, encoding: .utf8) ?? "{}" | ||
| } catch { | ||
| print("ROWND: Couldn't encode Framework Features") |
There was a problem hiding this comment.
You can use something like: logger.warn("Failed to encode framework features: \(String(describing: error)))") here to provide better formatting and error details (although it theoretically won't ever fail).
There was a problem hiding this comment.
Updated. We'll need to merge the Hub PR before this gets merged. The JS fails without the rownd.setSesssionStorage api
mhamann
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.