feat(auth): prevent sign-outs during poor network conditions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbyRadford
approved these changes
Nov 11, 2022
mhamann
force-pushed
the
handle-auth-errors
branch
from
e02304d
to
48514a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, users could be inadvertently signed-out during times of poor network conditions, disruptions, service downtime, etc even when their refresh token was still perfectly valid.
Now, we take a more nuanced approach such that transient network disruptions or unexpected HTTP status codes won't immediately result in a user being signed-out. Only an HTTP status code of 400 will do that. If the condition persists after several retries, we'll throw an error to the caller so they can take any action they deem appropriate (e.g., show an error to the user, show stale data, cache the action for later, etc).