fix: pass down intent from hub to apple/google sign-in #42
Conversation
| @@ -252,11 +252,13 @@ extension HubWebViewController: WKScriptMessageHandler, WKNavigationDelegate { | |||
| } | |||
|
|
|||
| case .triggerSignInWithApple: | |||
| guard case .triggerSignInWithApple(let signInWithAppleMessage) = hubMessage.payload else { return } | |||
There was a problem hiding this comment.
If no intent was initially passed, wouldn't payload be nil and thus nothing will happen when the corresponding button is pressed?
There was a problem hiding this comment.
Perhaps this could be simplified, but maybe something along these lines? Backward and forward compat, I think...
var signInWithAppleMessage: MessagePayload.TriggerSignInWithAppleMessage? = nil
if case .triggerSignInWithApple(let message) = hubMessage.payload {
signInWithAppleMessage = message
}
self.hubViewController?.hide()
Rownd.requestSignIn(with: .appleId, signInOptions: RowndSignInOptions(intent: signInWithAppleMessage?.intent))There was a problem hiding this comment.
When the intent is passed from the hub as undefined, the guard check still seems to be working.
| self.hubViewController?.hide() | ||
| Rownd.requestSignIn(with: .googleId, signInOptions: RowndSignInOptions(intent: signInWithGoogleMessage?.intent)) |
There was a problem hiding this comment.
@BobbyRadford Is it alright if I remove the hubViewController.hide() callback? I was seeing some error at times when the Hub would still be open and another hub webview would try to load.
There was a problem hiding this comment.
I think the idea behind this was to close the webview when the Sign in with Google dialog is shown so that once a user completes sign-in, the Rownd webview will be gone. Otherwise, a user will complete Google Sign-in, and Rownd will still be displayed. At the time, calling hide() was the only way I could figure out how to do this. If you can think of another way, or if things have changed since then and this is no longer a problem, feel free to remove.
There was a problem hiding this comment.
I moved hubViewController.hide() before the requestSignIn(with: .googleId) which seems to work for me. The hub closes right before the Google sign in dialog.
No description provided.