-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: $params helper examples #251
Comments
Thanks for spotting this. It seems there's something missing in the description. |
IIRC the behavior is the same as described here. |
Yes, in the V3 documentation this is made way clearer! :) |
Thing to be noted tho, during my tests i tryed a usage like "/subfolder/page/:id", while having a fallback page configured at root level in my folder structure, and instead of hitting the "/subfolder/page" with param { page: id }, it was going straight to the root level fallback. It only worked as intended when i configured it to use only URLSearchParams |
That sounds like a bug. Can you create a minimal reproducible? |
So i tryed to go back and reproduce the behaviour i stated above, but it turns out i was missing the |
I'm not sure this is the right channel, but since i'm in the topic and it could potentially be a new issue, i'm going to introduce it here. From what i'm testing now, it correctly writes the intended path in the browser history, but routify appears to be routing me back to the "/subfolder/index", by visiting the same url via the $url helper inside a link, or with the "back" browser button i reach correctly the intended page |
@gianmarco27 I'm not sure I follow. Could you give me a step by step of what you're doing, what's happening and what you're expecting? |
Upon a form submission, i'm trying to redirect to a success page which should contain the submitted informations. I would expect to be redirect to such page on success, what happens instead is i get navigated to such page, and then redirect to the same-level index.svelte file. is this type of usage |
I would have expected that to work. Are you using Routify 2? |
Yes i'm using 2.18.8 |
Current examples provided in the documentation are a bit misleading as they rapresent a usage of the $params helper function that does not follow the default implementation, it is specified below that by default the native URLSearchParams function is used, i believe it would be helpful and clearer, either to adapt the examples to the actual default usage, or add the custom function used to obtain such result, and highlight better that the default behaviour would be different from the one displayed in the example.
P.S. Awesome tool! keep it up :)
The text was updated successfully, but these errors were encountered: