Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring aydin.it.cnn to aydin.it.torch #122

Open
AhmetCanSolak opened this issue Apr 1, 2022 · 0 comments
Open

Refactoring aydin.it.cnn to aydin.it.torch #122

AhmetCanSolak opened this issue Apr 1, 2022 · 0 comments
Assignees
Milestone

Comments

@AhmetCanSolak
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
We are planning to drop tensorflow/keras dependencies and switch to pytorch. This is a big breaking change and it will be on multiple critical pivot points in the code base. One of those points is the aydin.it level API that we use to serve current tensorflow/keras models. Currently, aydin.it.cnn has so much business logic that is tightly bounded with current unet/jinet keras implementations. For the sake of a more modular design we are planning to change this. Also we can refine our aydin.it level API to comfort any model that might be implemented with pytorch, not only CNNs.

Describe the solution you'd like
I am here suggesting to refactor/re-write a new API on aydin.it level to serve all models implemented with torch right now and future models. As a complementary change, also, I am suggesting to rename our module to a more generic name such as aydin.it.torch.

Describe alternatives you've considered
An alternative idea could be implementing a new module for each new pytorch model in aydin.it level package. This would clutter the aydin.it subpackage and cause code-duplication (probably) often. Another alternative could be sticking to old approach and keep extending the amount business logic implemented in aydin.it.cnn but as we already experience this is not really a sustainable option.

@AhmetCanSolak AhmetCanSolak added this to the v0.2.0 milestone Apr 1, 2022
@AhmetCanSolak AhmetCanSolak self-assigned this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant