Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace circular-json with flatted #36

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Replace circular-json with flatted #36

merged 2 commits into from
Jan 9, 2019

Conversation

cktang88
Copy link
Contributor

Closes #35 .

@polarathene
Copy link

So is the CI error due to Mocha switching to ES6+ syntax but flat-cache enforcing "use strict" in the tests? How can that be corrected? or can it be safely ignored for the PR to get merged?

/home/travis/build/royriojas/flat-cache/node_modules/mocha/bin/mocha:10
const spawn = require('child_process').spawn;
^^^^^
SyntaxError: Use of const in strict mode.
    at exports.runInThisContext (vm.js:73:16)
    at Module._compile (module.js:443:25)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.

@coreyfarrell
Copy link

The error is due to current version of mocha requiring node.js >= 4.0.0. IMO .travis.yml should be updated to remove v0.10, probably add v8 and v10.

@royriojas royriojas merged commit b93aced into jaredwray:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants