Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserActivitiesView should limit search depth #51

Open
roysmith opened this issue Jul 20, 2020 · 1 comment
Open

UserActivitiesView should limit search depth #51

roysmith opened this issue Jul 20, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@roysmith
Copy link
Owner

Imagine we ask for:

count = 10
main=False
draft=True
others=False

on a user with 1 million edits but none to draft space. We'll iterate through all 1 million edits trying to find 10 drafts. There should be some circuit breaker which cuts the search off before then. Maybe never examine more than 10*count?

@roysmith roysmith added the bug Something isn't working label Jul 20, 2020
@roysmith roysmith changed the title UserActivitiesView should limit search dept UserActivitiesView should limit search depth Jul 20, 2020
@roysmith
Copy link
Owner Author

UserActivitiesView no longer exists, but the same issue applies to TimelineView.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant