Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest tweaking the setting "Stub PPU Traps" after PPU trap #10921

Merged
merged 3 commits into from Sep 30, 2021
Merged

Suggest tweaking the setting "Stub PPU Traps" after PPU trap #10921

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93e9e2b
Update PPUThread.cpp
elad335 Sep 24, 2021
d11be98
Update PPUThread.cpp
elad335 Sep 24, 2021
146bede
Update PPUThread.cpp
elad335 Sep 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion rpcs3/Emu/Cell/PPUThread.cpp
View file
Open in desktop
Expand Up @@ -1493,7 +1493,7 @@ void ppu_trap(ppu_thread& ppu, u64 addr)
// If stubbing is enabled, check current instruction and the following
if (!add || !vm::check_addr(ppu.cia, vm::page_executable) || !vm::check_addr(ppu.cia + add, vm::page_executable))
{
fmt::throw_exception("PPU Trap!");
fmt::throw_exception("PPU Trap! Sometimes tweaking the setting \"Stub PPU Traps\" can be a workaround to this crash.\nBest values depend on game code, if unsure try 1.");
}

ppu_log.error("PPU Trap: Stubbing %d instructions %s.", std::abs(static_cast<s32>(add) / 4), add >> 31 ? "backwards" : "forwards");
Expand Down