Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Temporarily disable readback predictions if failure rate exceeds 50% #5163

Merged
merged 2 commits into from
Sep 24, 2018
Merged

rsx: Temporarily disable readback predictions if failure rate exceeds 50% #5163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7155370
rsx: Disable predictions if 50% of predictions are wrong
kd-11 Sep 22, 2018
ea9293d
Merge branch 'master' into master
kd-11 Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion rpcs3/Emu/RSX/Common/texture_cache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,19 +1259,27 @@ namespace rsx
template <typename ...Args>
bool flush_memory_to_cache(const address_range &memory_range, bool skip_synchronized, u32 allowed_types_mask, Args&&... extra)
{
// Temporarily disable prediction if more than 50% of predictions are wrong. Also lower prediction pressure
if (m_num_cache_mispredictions > (m_num_cache_speculative_writes / 2) &&
m_num_cache_mispredictions > 8)
return false;

std::lock_guard lock(m_cache_mutex);
section_storage_type* region = find_flushable_section(memory_range);

//Check if section was released, usually if cell overwrites a currently bound render target
// Check if section was released, usually if cell overwrites a currently bound render target
if (region == nullptr)
return true;

// Skip if already synchronized
if (skip_synchronized && region->is_synchronized())
return false;

// Skip if type is not allowed
if ((allowed_types_mask & region->get_context()) == 0)
return true;

// Skip if more writes to the same target are likely
if (!region->writes_likely_completed())
return true;

Expand Down