Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstallPup: Fix exception on newline trim #5716

Merged
merged 1 commit into from Mar 13, 2019
Merged

InstallPup: Fix exception on newline trim #5716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion rpcs3/rpcs3qt/main_window.cpp
View file
Open in desktop
Expand Up @@ -565,7 +565,11 @@ void main_window::InstallPup(const QString& dropPath)
updatefilenames.end());

std::string version_string = pup.get_file(0x100).to_string();
version_string.erase(version_string.find('\n'));
size_t version_pos = version_string.find('\n');
if (version_pos != std::string::npos)
{
version_string.erase(version_pos);
}

const std::string cur_version = "4.84";

Expand Down