Add zchunk support to modifyrepo_c as well as for mergerepo_c and createrepo_c for extra metadata #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
Conan-Kudo
approved these changes
Jan 7, 2019
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
jdieter
changed the title
|
This branch has just grown massively huge, as it now includes full zchunk support in createrepo_c and mergerepo_c for extra metadata, and modifyrepo_c now has zchunk support. The first commit is a bug fix, while the next two are the new features, which required some pretty extensive changes. Unfortunately, I'm not sure that I can break it into any smaller pieces. |
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
|
Spaces after ifs please :) |
Signed-off-by: Jonathan Dieter <jdieter@gmail.com>
|
Done! :) |
|
@dmach, is there anything else you'd like me to do with this before you review it? |
Conan-Kudo
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes cr_close() so it doesn't error if zck_end_chunk returns a positive number.