Parse xml snippet in smaller parts (RhBug:1859689) #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libmodulemd doesn't always provide the error so we have to check before accessing the message.
If string passed to xmlParseChunk (function froml ibxml2) is too big the function errors out, its safer to parse the snippet in smaller parts. https://bugzilla.redhat.com/show_bug.cgi?id=1859689
|
I can confirm that this is fixed in the case where I originally discovered it :) Thanks @kontura! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If string passed to xmlParseChunk (function froml libxml2) is too big the function errors out, its safer to parse the snippet in
smaller parts.
Also adds a unit test for this case.
https://bugzilla.redhat.com/show_bug.cgi?id=1859689
The third commit is unrelated and fixes an issue of accessing possible NULL pointer to
tmp_err.