updateinfo: *_date attributes as Python datetime objects #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
UpdateRecord.issued_date
andUpdateRecord.modified_date
be actual Python datetime objects, rather than plain strings.A few caveats, on which I'd like feedback/pointers:
#include <python2.7/datetime.h>
) is obviously wrong. Having never used cmake before, though, I can't seem to figure out how to include the proper header, based on the version of Python detected at build time. 馃槙PyDateTime_IMPORT
macro first. Currently, I'm calling it in the constructor of theUpdateRecord
class, which is not necessarily ideal. Where would be the proper place to call it?Other than that, it makes for a much nicer API: