Skip to content

Commit

Permalink
Document dummy backend in macros, warn on dummy fallback
Browse files Browse the repository at this point in the history
As the dummy backend supports no operations whatsoever, using it as
a fallback if all else fails needs to emit a warning, not debug goo.
  • Loading branch information
pmatilai committed Oct 21, 2019
1 parent 6253d8a commit a2522cf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/backend/dbi.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ dbDetectBackend(rpmdb rdb)

if (rdb->db_ops == NULL) {
rdb->db_ops = &dummydb_dbops;
rpmlog(RPMLOG_DEBUG, "using dummy database, installs not possible\n");
rpmlog(RPMLOG_WARNING, "using dummy database, installs not possible\n");
}

if (db_backend)
Expand Down
1 change: 1 addition & 0 deletions macros.in
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,7 @@ package or when debugging this package.\
# lmdb Lightning Memory-mapped Database
# ndb new data base format
# sqlite Sqlite database
# dummy dummy backend (no actual functionality)
#
%_db_backend bdb

Expand Down

0 comments on commit a2522cf

Please sign in to comment.