-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEVR provides in source package lead to rpmbuild errors #1189
Comments
Ack, I'll look into it. Thanks for reporting. |
Fixes a regression introduced by commit 75ec16e: the newly added provides of to-be-built packages end up being matched against installed packages during build dependency checking. Which obviously doesn't make any sense, Explicitly skip checks against source provides, similarly to what we already did with obsoletes. Fixes: rpm-software-management#1189
I wonder if the added provides also can lead to problems if we have a transaction with both source and binary packages. The provides from the source packages must not satisfy the dependencies of the binary packages. Another thing to test would be a spec file that has a BuildRequires to one of the packages it builds. For example, gcc.spec might have a |
This case is indeed affected too, but also cured by #1192. However the commit message end comments in the PR are off the mark a bit, I'll update... |
Why is that cured by #1192? It just changes things for conflicts of installed packages. My example was about a build requires being satisfied by a provides of a source package. I think this needs to be fixed in rpmal.c |
Fixes a regression introduced by commit 75ec16e: the newly added provides of to-be-built packages end up being matched against installed packages during build dependency checking, such package satisfying its own build-requires and conflicts in installed packages. Explicitly skip checks against source provides, similarly to what we already did with obsoletes. Fixes: rpm-software-management#1189
Oops, false testing+thinking on my behalf. Too much disturbance in the force today... |
Fixes regressions from commit 75ec16e: the newly added provides of to-be-built packages were being used for dependency resolution, such as spec satifying its own buildrequires, and matched against conflicts in installed packages. Source packages cannot obsolete anything or provide capabilities or files to transactions, don't add them to rpmal at all. Explicitly skip checks against source provides, similarly to what we already did with obsoletes. Fixes: rpm-software-management#1189
Okay, now it should really be covered by #1192. |
Fixes regressions from commit 75ec16e: the newly added provides of to-be-built packages were being used for dependency resolution, such as spec satifying its own buildrequires, and matched against conflicts in installed packages. Source packages cannot obsolete anything or provide capabilities or files to transactions, don't add them to rpmal at all. Explicitly skip checks against source provides, similarly to what we already did with obsoletes. Fixes: #1189
This is a regression caused by commit 75ec16e. The provides added to the source rpms will be checked against the dependencies of the installed packages. Because of this you will get an error if you try to build an rpm where the package name matches a conflict of an installed package.
I.e.:
The text was updated successfully, but these errors were encountered: