Don't check source package provides against installed conflicts #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan-Kudo
approved these changes
Apr 22, 2020
Fixes regressions from commit 75ec16e: the newly added provides of to-be-built packages were being used for dependency resolution, such as spec satifying its own buildrequires, and matched against conflicts in installed packages. Source packages cannot obsolete anything or provide capabilities or files to transactions, don't add them to rpmal at all. Explicitly skip checks against source provides, similarly to what we already did with obsoletes. Fixes: rpm-software-management#1189
|
Updated to cover the other breakage too, eg spec satisfying its own build-requires. |
mlschroe
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regressions from commit 75ec16e: the newly added provides of to-be-built packages were being used for dependency resolution, such as spec satifying its own buildrequires, and matched against conflicts in installed packages.
Source packages cannot obsolete anything or provide capabilities or files to transactions, don't add them to rpmal at all. Explicitly skip checks against source provides, similarly to what we already did with obsoletes.
Fixes: #1189