Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm2archive: Support uncompressed output #1530

Closed
cgwalters opened this issue Feb 5, 2021 · 3 comments · Fixed by #1657
Closed

rpm2archive: Support uncompressed output #1530

cgwalters opened this issue Feb 5, 2021 · 3 comments · Fixed by #1657
Assignees
@ffesti

Comments

@cgwalters
Copy link
Contributor

See coreos/rpm-ostree#2458
Basically it'd be inefficient for rpm-ostree to use rpm2archive today because it always compresses the output which we'd need to immediately uncompress again.

I looked at patch for this but got slightly lost in learning the ins&outs of popt arg parsing, but if this sounds ok I can try to finish that.
@ffesti ffesti self-assigned this Feb 12, 2021
@ffesti
Copy link
Contributor

ffesti commented Feb 12, 2021

If I had imagined the tool would be used in such a central role I might had added a few more options right from the start. Adding those features should pretty easy though. Feel free to bug me if you need help.

ffesti added a commit to ffesti/rpm that referenced this issue Apr 26, 2021
@ffesti
Add --nocompression option to rpm2archive
1e19302 
Also use popt for the command line handling. As we are using librpm
anyway there is no reason to keep the dependencies low (as with
rpm2cpio).

Resolves: rpm-software-management#1530
@ffesti ffesti mentioned this issue Apr 26, 2021
Merged
@ffesti
Copy link
Contributor

ffesti commented Apr 27, 2021

After considering to expose more of libarchive's functionality like many compression methods and archive formats I opted to only add an option for uncompressed output - as requested.
Is the PR what you had in mind?

ffesti added a commit that referenced this issue May 10, 2021
@ffesti
Add --nocompression option to rpm2archive
d8a1691 
Also use popt for the command line handling. As we are using librpm
anyway there is no reason to keep the dependencies low (as with
rpm2cpio).

Resolves: #1530
@ffesti
Copy link
Contributor

ffesti commented May 31, 2021

Guess this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffesti ffesti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --nocompression option to rpm2archive ffesti/rpm
2 participants
@cgwalters @ffesti