Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --nocompression option to rpm2archive #1657

Merged
merged 1 commit into from May 10, 2021
Merged

Add --nocompression option to rpm2archive #1657

merged 1 commit into from May 10, 2021

Conversation

ffesti
Copy link
Contributor

@ffesti ffesti commented Apr 26, 2021

Also use popt for the command line handling. As we are using librpm
anyway there is no reason to keep the dependencies low (as with
rpm2cpio).

Resolves: #1530

@ffesti
Add --nocompression option to rpm2archive
1e19302 
Also use popt for the command line handling. As we are using librpm
anyway there is no reason to keep the dependencies low (as with
rpm2cpio).

Resolves: rpm-software-management#1530
pmatilai
pmatilai approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@pmatilai pmatilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't try but looks okay to me.

FWIW, rpm2cpio could use porting to popt too. It's using librpm too so if popt is broken then it wont work anyway. I think the main reason it doesn't currently use popt is that it actually predates popt by almost a year.

cgwalters
cgwalters approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a quick test and it works for me. Thanks!

@ffesti ffesti merged commit d8a1691 into rpm-software-management:master May 10, 2021
@ffesti ffesti deleted the nocompress branch May 13, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

@Conan-Kudo Conan-Kudo Conan-Kudo approved these changes

@pmatilai pmatilai pmatilai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rpm2archive: Support uncompressed output
4 participants
@ffesti @cgwalters @Conan-Kudo @pmatilai