Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for NULL after dereference in rpmfi.c #1782

Closed
ex0z3 opened this issue Sep 21, 2021 · 0 comments · Fixed by #1784
Closed

Check for NULL after dereference in rpmfi.c #1782

ex0z3 opened this issue Sep 21, 2021 · 0 comments · Fixed by #1784
Assignees
@ffesti

Comments

@ex0z3
Copy link

ex0z3 commented Sep 21, 2021 •
edited

Issues were detected by static analyzer:
#1
#2
#3
#4
#5
#6
in call arguments: fi->files, fi ? fi->i : -1
in 1st argument - we dereferencing a pointer, in 2nd argument we check this pointer for null
@ffesti ffesti self-assigned this Sep 22, 2021
ffesti added a commit to ffesti/rpm that referenced this issue Sep 22, 2021
@ffesti
Check file iterator for being NULL consistently
9ed6084 
No point in allowing NULL only for one of the arguments.

Thanks to ex0z3 (https://github.com/ex0z3) for reporting!

Resolves: rpm-software-management#1782
@ffesti ffesti mentioned this issue Sep 22, 2021
Merged
ffesti added a commit that referenced this issue Sep 28, 2021
@ffesti
Check file iterator for being NULL consistently
470498b 
No point in allowing NULL only for one of the arguments.

Thanks to ex0z3 (https://github.com/ex0z3) for reporting!

Resolves: #1782
mikhailnov pushed a commit to mikhailnov/rpm that referenced this issue Sep 30, 2021
@ffesti @mikhailnov
Check file iterator for being NULL consistently
0d2f34b 
No point in allowing NULL only for one of the arguments.

Thanks to ex0z3 (https://github.com/ex0z3) for reporting!

Resolves: rpm-software-management#1782
dmnks pushed a commit to dmnks/rpm that referenced this issue Jun 7, 2022
@ffesti @dmnks
Check file iterator for being NULL consistently
0757f8b 
No point in allowing NULL only for one of the arguments.

Thanks to ex0z3 (https://github.com/ex0z3) for reporting!

Resolves: rpm-software-management#1782
(cherry picked from commit 470498b)
dmnks pushed a commit to dmnks/rpm that referenced this issue Jun 7, 2022
@ffesti @dmnks
Check file iterator for being NULL consistently
df14e77 
No point in allowing NULL only for one of the arguments.

Thanks to ex0z3 (https://github.com/ex0z3) for reporting!

Resolves: rpm-software-management#1782
(cherry picked from commit 470498b)
dmnks pushed a commit to dmnks/rpm that referenced this issue Jun 7, 2022
@ffesti @dmnks
Check file iterator for being NULL consistently
75b6ec6 
No point in allowing NULL only for one of the arguments.

Thanks to ex0z3 (https://github.com/ex0z3) for reporting!

Resolves: rpm-software-management#1782
(cherry picked from commit 470498b)
dmnks pushed a commit to dmnks/rpm that referenced this issue Jun 8, 2022
@ffesti @dmnks
Check file iterator for being NULL consistently
078d94f 
No point in allowing NULL only for one of the arguments.

Thanks to ex0z3 (https://github.com/ex0z3) for reporting!

Resolves: rpm-software-management#1782
(cherry picked from commit 470498b)
dmnks pushed a commit that referenced this issue Jul 1, 2022
@ffesti @dmnks
Check file iterator for being NULL consistently
b058fa7 
No point in allowing NULL only for one of the arguments.

Thanks to ex0z3 (https://github.com/ex0z3) for reporting!

Resolves: #1782
(cherry picked from commit 470498b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffesti ffesti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check file iterator for being NULL consistently ffesti/rpm
2 participants
@ffesti @ex0z3