Check file iterator for being NULL consistently #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No point in allowing NULL only for one of the arguments. Thanks to ex0z3 (https://github.com/ex0z3) for reporting! Resolves: rpm-software-management#1782
pmatilai
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
The existing NULL checks probably predate existience of fi->files, and nobody (cough) thought to check to double-check for those NULLs when that was introduced. At two separate checks, it's a bit borderline whether it would be more readable with the check moved outside the call. The reason it's written the way it is, is to avoid having to maintain error codes twice, but that could be achieved in other ways too.
|
Yeah, not beautiful but just good enough for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No point in allowing NULL only for one of the arguments.
Thanks to ex0z3 (https://github.com/ex0z3) for reporting!
Resolves: #1782