Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-macro-helper should not have shebang and x flag #387

Closed
hroncok opened this issue Jan 30, 2018 · 2 comments
Closed

python-macro-helper should not have shebang and x flag #387

hroncok opened this issue Jan 30, 2018 · 2 comments

Comments

@hroncok
Copy link
Contributor

hroncok commented Jan 30, 2018

Looking at 7ac3f07 the %{_rpmconfigdir}/python-macro-helper file is always invoked with %{__python} and thus doesn't need a shebang and an executable flag. Since %{__python} can be redefined, having a hardcoded /usr/bin/python shebang that is never used is misleading.
@hroncok
Copy link
Contributor Author

hroncok commented Jan 31, 2018 •
edited
Loading

Also, this makes the rpm-build package in fedora require python2: https://bugzilla.redhat.com/show_bug.cgi?id=1538657

pmatilai added a commit that referenced this issue Feb 12, 2018
@pmatilai
Avoid hard dependency on python via the python macro helper script (#387
faf7d87 
)

Rpm always executes the script as an argument to /usr/bin/python[23], so
it doesn't need a shebang and then it shouldn't be executable either.
@pmatilai
Copy link
Member

Fixed in commit faf7d87, thanks for the report

pmatilai added a commit that referenced this issue Jun 29, 2018
@pmatilai
Avoid hard dependency on python via the python macro helper script (#387
613fc8b 
)

Rpm always executes the script as an argument to /usr/bin/python[23], so
it doesn't need a shebang and then it shouldn't be executable either.

(cherry picked from commit faf7d87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hroncok @pmatilai