Speed up dependency solving by using pool ids #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to get rid of unneeded id->str->id roundtrips.
We already know the ids, so just use them for fingerprinting.
If the directories match the fingerprint is not used.
This needs less memory and it should also be faster as the dependencies are already available in id form.
mlschroe
added
DONT
|
This pull request introduces 1 alert when merging d9ffe24 into 153c5c2 - view on LGTM.com new alerts:
|
The rpmalCreate() function is called in two places, in both of them the arguments are all read from the transaction set. So simplify the code by passing the ts to rpmalCreate() and getting the values in the constructor.
pmatilai
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
I thought I actually removed the ts as an argument to rpmalCreate() back somewhen as part of overall efforts to minimize what has access to the full transaction set, but seems that's not the case. Anyway, I can live with that, it does of course simplify the argument list.
Nice optimization + cleanup, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of a couple of id->str->id roundtrips and also makes the dependency hashes in rpmtsCheck() use pool ids instead of strings.