Improve macro traceback behavior #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rationale behind the change was to suppress the excessive output when trying to expand a recursive macro definition (RhBug:613010) but this is not so good as it effectively suppresses *all* backtrace output, include those requested by %trace where the other half is printed to stderr and the other half in the debug log because of the change. Besides making things consistent, this also avoids deadlock on `rpm -vv --eval '%trace'`. This reverts commit 7f22020. Fixes: rpm-software-management#1418
Only dump out macro tracebacks in verbose mode, which incidentally rpmbuild normally runs in. Sadly our tracebacks are not as useful as they could be, but improving that is a separate topic...
Should make macro debugging a little saner, including but not limited to Lua. Fixes: rpm-software-management#545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert commit 7f22020 to fix #1418 and make things more consistent.
We always want the tracing output on stderr, but we might not always want the traces so conditionalize the traceback outputing to only occur on verbose levels.
Also generate actually meaningful tracebacks by supplying the macro names where possible.