Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve macro traceback behavior #1515

Merged
merged 3 commits into from Jan 29, 2021

Commits on Jan 25, 2021

  1. Revert "Redirect macro stack backtrace printing to debug log."

    The rationale behind the change was to suppress the excessive output
    when trying to expand a recursive macro definition (RhBug:613010) but
    this is not so good as it effectively suppresses *all* backtrace output,
    include those requested by %trace where the other half is printed to
    stderr and the other half in the debug log because of the change.
    
    Besides making things consistent, this also avoids deadlock on
    `rpm -vv --eval '%trace'`.
    
    This reverts commit 7f22020.
    
    Fixes: rpm-software-management#1418
    pmatilai committed Jan 25, 2021
    Copy the full SHA
    d925850 View commit details
    Browse the repository at this point in the history
  2. Conditionalize macro traceback dump on rpm verbosity level

    Only dump out macro tracebacks in verbose mode, which incidentally
    rpmbuild normally runs in.
    
    Sadly our tracebacks are not as useful as they could be, but improving
    that is a separate topic...
    pmatilai committed Jan 25, 2021
    Copy the full SHA
    fbe536a View commit details
    Browse the repository at this point in the history
  3. Actually report the involved macro names in macro tracebacks

    Should make macro debugging a little saner, including but not limited
    to Lua.
    
    Fixes: rpm-software-management#545
    pmatilai committed Jan 25, 2021
    Copy the full SHA
    ecf3a13 View commit details
    Browse the repository at this point in the history