RFC Building with PIC enabled is not supported in OS/2. #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan-Kudo
approved these changes
Nov 3, 2017
|
The error in the CI is due to its dependency on #349. |
|
Erk, wrong PR for this. |
|
The CI failures in this PR are unrelated to this change. |
pmatilai
added a commit
that referenced
this pull request
Feb 19, 2018
These things are up to distro/platform build policies, it's not as if rpm actually required position independent code. And as it happens, doing the right thing renders PR #350 unnecessary.
|
The right thing to do is actually not have rpm mess with -fPIC and friends at all, these are up to distro/platform policies etc. Done in commit d7dfd0d so this PR is not needed at all. And by doing the right thing we actually end up reducing the need for those OS2-specific patches, and those kind of changes are always welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable PIC flags in OS/2 build.