Put all Perl-related macros in a single file. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 13, 2016 16:09
If the '%perl_...' macros are '%define'd in 'macros[.in]', they are automatically loaded on startup, so '%include'ing the extra 'macros.perl' in the spec file is redundant. In case that the '%perl_...' macros are sufficiently important to be '%define'd automatically on startup, the separate file 'macros.perl' can savely be removed from the distribution.
Put _all_ Perl stuff into 'macros.perl'.
|
Not sure if those macro can just be hidden away. We'd need to check how much packages this is going to break before doing such a change. It might be necessary to go the opposite direction (including the macros.perl unconditionally) and leave removing it again to the distros. |
|
Personally, I don't use the Perl macros, but I know of at least this project that makes use of |
|
Looks like those macros are being used to build some packages and just removing them is probably not an option for now. Still I think you have a very valid point in that the macros are a mess and deserve cleaning up. See rpm-ecosystem ML for a broader discussion on the topic. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
%perl_...macros are%defined inmacros[.in], they are automatically loaded on startup, so%includeing the extramacros.perlin the spec file is redundant.In case that the
%perl_...macros are sufficiently important to be%defined automatically on startup, the separate filemacros.perlcan savely be removed from the distribution.