Split verbose make flags to a separate macro #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan-Kudo
suggested changes
Jul 25, 2019
| @@ -1073,7 +1073,8 @@ package or when debugging this package.\ | |||
|
|
|||
| #------------------------------------------------------------------------------ | |||
| # The "make" analogue, hiding the _smp_mflags magic from specs | |||
| %make_build %{__make} %{_make_output_sync} %{?_smp_mflags} V=1 VERBOSE=1 | |||
| %_make_verbose V=1 VERBOSE=1 | |||
| %make_build %{__make} %{_make_output_sync} %{?_smp_mflags} %{_make_verbose} | |||
There was a problem hiding this comment.
%{_make_verbose} -> %{?_make_verbose}
Also, can you put the %_make_verbose macro in its own "section" like %_make_output_sync was?
There was a problem hiding this comment.
If I did everything correctly, I believe I've done what you requested.
Adding V=1 is known to break at least one upstream Makefile, so move the verbosity options to a separate macro to simplify the workaround.
jasontibbitts
force-pushed
the
make_build_verbose
branch
from
0a463e5
to
ac4d4e8
Compare
Conan-Kudo
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I didn't screw this up, it should help with #798. It just pulls the
V=1 VERBOSE=1bit out to a separate macro to make it easier to override.