Make database backends self-aware #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlschroe
approved these changes
Oct 21, 2019
Refactor the hand-written separate tests into an array walk now that we can. No functional changes, except that there's no more special fallback for BDB.
ndb and sqlite have control of their own paths, BDB and LMDB do things differently and dummydb doesn't have a path at all.
As the dummy backend supports no operations whatsoever, using it as a fallback if all else fails needs to emit a warning, not debug goo.
rpmdbStat() can be used without an open rpmdb handle similar to stat() and rpmdbFStat() takes an open rpmdb handle, akin fstat(). The rationale for these calls is to give API users a backend-independent way of obtaining data about the database's existence, timestamps etc.
|
Rebased and added both rpmdbStat() and rpmdbFStat() now. |
😰 |
Conan-Kudo
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay okay, maybe not...
Add name and path members to backend db_ops struct, use them for configuring and detecting, and misc related tweaks.
Started doing this for implementing rpmdbStat(), but got stuck wondering about the API: my initial version requires an open rpmdb for stat'ing, which limits its usefulness. Perhaps there should be separate calls for an open database and non-open one, just like there's fstat() and stat(). Thoughts?