Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc minor fixes/cleanups suggested by LGTM #920

Merged
merged 5 commits into from Oct 30, 2019
Merged

Misc minor fixes/cleanups suggested by LGTM #920

merged 5 commits into from Oct 30, 2019

Conversation

pmatilai
Copy link
Member

No description provided.

@pmatilai
Fix parameter hiding in scriptlet expansion
5e453b0 
Harmless but also unnecessary obfuscation.
@pmatilai
Fix parameter hiding in rpmdsNewPool()
90382e5 
Harmless but also unnecessary obfuscation.
@pmatilai
Fix global variable hiding in Fdopen()
d47bdd3 
Harmless but also unnecessary obfuscation, when originally written the
thing we now know as zstd was 20 years in the future.
@pmatilai
Remove redundant check, size is unsigned so condition is always true
3465811
@pmatilai
Drop bogus const from validName() return
a88fe3c
@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2019

This pull request fixes 6 alerts when merging a88fe3c into 819c6c8 - view on LGTM.com

fixed alerts:

  • 3 for Declaration hides parameter
  • 1 for Unsigned comparison to zero
  • 1 for Constant return type
  • 1 for Local variable hides global variable

@ffesti ffesti self-assigned this Oct 30, 2019
@ffesti ffesti merged commit 4cae7bc into rpm-software-management:master Oct 30, 2019
@pmatilai pmatilai deleted the lgtm-pr branch November 4, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ffesti ffesti

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmatilai @ffesti