Eliminate uses of non-threadsafe locatime() and ctime() functions #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the _print_pkts global to librpmio where the two relevant users can actually access it, and make them use it. This has been broken for years...
LGTM flags localtime() as a "dangerous" function, which seems a bit over the top to me, but as we're flirting with threads, it certainly is not thread-safe.
POSIX.1-2008 marked ctime() as obsolete and recommends strftime() instead. We get two flies on one stroke as ctime() is also classified "dangerous" by LGTM due to not being thread-safe. strftime(..., "%c"...) isn't exactly the same as ctime() but is consistent with what we use elsewhere and sufficient for debug purposes anyway.
|
This pull request fixes 4 alerts when merging 72b1772 into 63930cd - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LGTM pointed out localtime() and ctime() are not thread-safe, and additionally ctime() is considered obsolete since POSIX.1-2008. Replace with localtime_r() and strftime() instead.
Long broken --prtpkts debug switch is fixed in a separate commit to have means of testing the strftime() change.