scripts/pythondistdeps: Only add setuptools requirement for egg-info … #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. @hroncok r? |
Conan-Kudo
approved these changes
Dec 9, 2019
|
Pretty straight forward. |
hroncok
reviewed
Jan 1, 2020
| dist.get_entry_map('gui_scripts')): | ||
| if ((dist.get_entry_map('console_scripts') or | ||
| dist.get_entry_map('gui_scripts')) and | ||
| (lower.endswith('.egg') or |
There was a problem hiding this comment.
I don't know about egg. Can it even have entrypoints?
There was a problem hiding this comment.
I think so... If I "bdist_egg" the molecule package, and then install the resulting egg, the console_script is installed. However, I don't get useful results from this script on egg files. I'm unclear on whether we ever package egg (or wheel) files, so I'm not actually sure whether that's something that needs to be reviewed and fixed, or dropped.
There was a problem hiding this comment.
OK. we can keep it be, until proven otherwise.
jollaitbot
pushed a commit
to sailfishos-mirror/python-rpm-generators
that referenced
this pull request
Apr 14, 2020
- Handle version ending with ".*" - Handle compatible-release operator "~=" - Use rich deps for semantically versioned dependencies - Match Python version if minor has multiple digits (e.g. 3.10) - Only add setuptools requirement for egg-info packages rpm-software-management/rpm#951 rpm-software-management/rpm#973 rpm-software-management/rpm#982 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1758141 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1777382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scripts/pythondistdeps: Only add setuptools requirement for egg-info packages.
This should address issue #954