scripts/pythondistdeps: Only print rich dep list when required to. #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should resolve #981 |
|
gordonmessmer
force-pushed
the
issue_981
branch
from
1c59148
to
d8d1da5
Compare
It would be very cool if we could actually mangle this to a proper RPM notation, but this is definitely outside of the scope of this PR. |
Conan-Kudo
approved these changes
Dec 20, 2019
|
@gordonmessmer You beat me to it. Thanks for this! 👍 |
|
@Conan-Kudo Seems only right that I fix what I broke. :) |
|
@ignatenkobrain I started a repo to flesh out some of the requirement conversions from python dist tools to rpm. It doesn't mangle versions right now, but maybe you could open an issue there and describe what should happen? |
|
Given However, #996 fixes that. |
jollaitbot
pushed a commit
to sailfishos-mirror/python-rpm-generators
that referenced
this pull request
Apr 14, 2020
- Handle version ending with ".*" - Handle compatible-release operator "~=" - Use rich deps for semantically versioned dependencies - Match Python version if minor has multiple digits (e.g. 3.10) - Only add setuptools requirement for egg-info packages rpm-software-management/rpm#951 rpm-software-management/rpm#973 rpm-software-management/rpm#982 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1758141 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1777382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.