Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBCode Tag Workarounds #106

Closed
Alteras1 opened this issue Apr 24, 2024 · 2 comments · Fixed by #120
Closed

BBCode Tag Workarounds #106

Alteras1 opened this issue Apr 24, 2024 · 2 comments · Fixed by #120
Labels
todo Highly likely planned actions

Comments

@Alteras1
Copy link
Contributor

Due to how the built in markdown engine processes inline and block level bbcodes, some specific tag orders aren't supported.

For example:
image

likely workaround would be to just add those simple default tags (italic, bold, underline, etc.) manually ourselves to the BBob plugin.

@Alteras1 Alteras1 added the todo Highly likely planned actions label Apr 24, 2024
@Alteras1
Copy link
Contributor Author

I think this would only apply to the ones marked as inline bbcode in the markdown engine? We'd probably need to read through the source code to grab them

@kyuukestu
Copy link
Collaborator

Hi! I whipped up a few tests for italics, bold, underline, & strike-through and I found that discourse automatically converts these tags to their native versions when the post is baked.

Here's the code in the preview:
image

And here's what it turns into after being baked:
image

Alteras1 added a commit that referenced this issue Jun 13, 2024
Alteras1 added a commit that referenced this issue Jun 16, 2024
Alteras1 added a commit that referenced this issue Jun 16, 2024
…and underline (#120)

* chore: Add discourse core replacement tags for bold, italic, strike, and underline

fixes BBCode Tag Workarounds #106

* Reattach loadscript for bbcode parser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Highly likely planned actions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants