Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures by resolving RuboCop offenses #12

Merged
merged 2 commits into from
Feb 13, 2018

Conversation

garettarrowood
Copy link
Collaborator

Resolves RuboCop failures present in travis build failure on master. These changes make rubocop complete successfully. Before starting, these were the 5 reported offenses:

Offenses:

lib/modis.rb:31:3: W: Lint/DuplicateMethods: Method Modis.connection_pool is defined at both lib/modis.rb:23 and lib/modis.rb:31.
  def self.connection_pool
  ^^^
spec/spec_helper.rb:6:5: C: Style/MixinUsage: include is used at the top level. Use inside class or module.
    include SimpleCovHelper
    ^^^^^^^^^^^^^^^^^^^^^^^
lib/modis/persistence.rb:196:1: W: Lint/MissingCopEnableDirective: Re-enable Metrics/AbcSize cop with # rubocop:enable after disabling it.
    # rubocop:disable Metrics/AbcSize, Metrics/PerceivedComplexity
^
lib/modis/persistence.rb:237:28: C: Performance/HashEachMethods: Use each_key instead of each.
        changed_attributes.each do |k, _|
                           ^^^^
lib/modis/attribute.rb:56:39: C: Style/EvalWithLocation: Use __LINE__ + 1 instead of __LINE__, as they are used by backtraces.
        class_eval <<-RUBY, __FILE__, __LINE__

@Tonkpils
Copy link
Collaborator

👍 Thank you so much for taking care of these fixes!

@Tonkpils Tonkpils merged commit 7b65367 into rpush:master Feb 13, 2018
@garettarrowood garettarrowood deleted the fix_ci_failures branch February 13, 2018 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants