Fix CI failures by resolving RuboCop offenses

lib/modis.rb

@@ -20,23 +20,31 @@ module Modis
   @mutex = Mutex.new
 
   class << self
-    attr_accessor :connection_pool, :redis_options, :connection_pool_size,
-                  :connection_pool_timeout
-  end
+    attr_writer :redis_options, :connection_pool_size, :connection_pool_timeout,
+                :connection_pool
 
-  self.redis_options = { driver: :hiredis }
-  self.connection_pool_size = 5
-  self.connection_pool_timeout = 5
+    def redis_options
+      @redis_options ||= { driver: :hiredis }
+    end
 
-  def self.connection_pool
-    return @connection_pool if @connection_pool
-    @mutex.synchronize do
-      options = { size: connection_pool_size, timeout: connection_pool_timeout }
-      @connection_pool = ConnectionPool.new(options) { Redis.new(redis_options) }
+    def connection_pool_size
+      @connection_pool_size ||= 5
+    end
+
+    def connection_pool_timeout
+      @connection_pool_timeout ||= 5
+    end
+
+    def connection_pool
+      return @connection_pool if @connection_pool
+      @mutex.synchronize do
+        options = { size: connection_pool_size, timeout: connection_pool_timeout }
+        @connection_pool = ConnectionPool.new(options) { Redis.new(redis_options) }
+      end
     end
-  end
 
-  def self.with_connection
-    connection_pool.with { |connection| yield(connection) }
+    def with_connection
+      connection_pool.with { |connection| yield(connection) }
+    end
   end
 end

lib/modis/attribute.rb

@@ -53,7 +53,7 @@ def attribute(name, type, options = {})
         end
         RUBY
 
-        class_eval <<-RUBY, __FILE__, __LINE__
+        class_eval <<-RUBY, __FILE__, __LINE__ + 1
           def #{name}
             attributes['#{name}']
           end

lib/modis/persistence.rb

@@ -223,6 +223,7 @@ def persist
 
       future
     end
+    # rubocop:enable Metrics/AbcSize, Metrics/PerceivedComplexity
 
     def coerced_attributes
       attrs = []
@@ -234,8 +235,8 @@ def coerced_attributes
           end
         end
       else
-        changed_attributes.each do |k, _|
-          attrs << k << coerce_for_persistence(attributes[k])
+        changed_attributes.each_key do |key|
+          attrs << key << coerce_for_persistence(attributes[key])
         end
       end
 

spec/spec_helper.rb

@@ -3,7 +3,7 @@
 unless ENV['TRAVIS']
   begin
     require './spec/support/simplecov_helper'
-    include SimpleCovHelper
+    include SimpleCovHelper # rubocop:disable Style/MixinUsage
     start_simple_cov('unit')
   rescue LoadError
     puts "Coverage disabled."