Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modis for Rails 5.2 support #4

Merged
merged 1 commit into from
Dec 25, 2018

Conversation

garettarrowood
Copy link
Contributor

@garettarrowood garettarrowood commented Dec 21, 2018

@aried3r - See rpush/modis#19 for modis's upgrade to support Rails 5.2 .

@aried3r
Copy link
Member

aried3r commented Dec 21, 2018

Hey, thanks for the PR!

Is it necessary to force version 3+ of Modis? 2 should still work for Rails <5.2, right? Maybe we can relax the requirement a bit.

@garettarrowood
Copy link
Contributor Author

modis 2.1 does work for Rails <5.2. But 3.0 works for all maintained versions of Ruby and Rails.

We (added then) removed CI testing for Rails version <4.2. There did appear to be some issues with later versions of cRuby & jRuby with Rails 4.0 & 4.1. However, I believe those issues were there before. Those combos just were not being tested. In other words, there weren't any backwards compatible breaking changes added to the new release.

The version could be relaxed with a >= 2.0 specification. But I can't think of a benefit of doing so.

@aried3r
Copy link
Member

aried3r commented Dec 25, 2018

Normally I would disagree and keep compatibility with older versions, but since this gem is basically empty I think it will be ok, since people probably don't depend on modis directly if they use this gem.

@aried3r aried3r merged commit 2718c95 into rpush:master Dec 25, 2018
@garettarrowood garettarrowood deleted the update_modis branch December 25, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants