Modified Job save and refresh to support additional, third party job attributes

[selwin]

Hi there,

Attached is a patch that persists additional Job attributes in Redis. So now you can do:

job = Job.create(func)
job.foo = 'bar'
job.save() # Will save store 'foo' 

Any thoughts regarding the implementation?

[nvie]

Looks great at first sight. Will play with it a bit later tonight, I think. Big thanks for this one!

[nvie]

Thanks, merged it. However, I see it's breaking the unit tests now. Will have to look into this later.

[selwin]

Hmm, really? It passes all tests on my Mac, Python 2.7.1.

On Jul 18, 2012, at 4:02 AM, Vincent Driessen
reply@reply.github.com
wrote:

Thanks, merged it. However, I see it's breaking the unit tests now. Will have to look into this later.

---

Reply to this email directly or view it on GitHub:
#91 (comment)

[nvie]

It doesn't do in the merged result (the latest master). It's related to other patches I accepted yesterday.

[nvie]

I've set up Travis CI (it was about time!) to catch these automagically for me in the future. You can check the current build failure here: https://secure.travis-ci.org/#!/nvie/rq

Unfortunately, I'll have to look into the details at a later point in time. I'd appreciate it if you could take a look at it as well.

[selwin]

Alright, I'll try to take a look at it tonight.

Win~

On Wed, Jul 18, 2012 at 2:49 PM, Vincent Driessen
reply@reply.github.com
wrote:

I've set up Travis CI (it was about time!) to catch these automagically for me in the future. You can check the current build failure here: https://secure.travis-ci.org/#!/nvie/rq

Unfortunately, I'll have to look into the details at a later point in time. I'd appreciate it if you could take a look at it as well.

---

Reply to this email directly or view it on GitHub:
#91 (comment)