Should skipLoadingOnRefresh be off by default? #3209
AhmedLSayed9
started this conversation in
General
Replies: 1 comment 2 replies
-
Why do you want to turn this off exactly? Don't forget, |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I understand that
skipLoadingOnRefresh
is on by default because the common usage is withRefreshIndicator
.But, there are quite a few other cases where it's needed to be used and I always find folks get confused of "why my loading is not showing" and we've to tell them it's a feature and you've to turn it off.
I'm rethinking that it's easier to turn it on for
RefreshIndicator
than turning it off for other use cases (we usually forget and catch this while testing the app).Being off by default seems more natural, and we can make a reusable extension for
RefreshIndicator
:imo, this is more predictable and easier to spot than using an extension for the whole app to turn off
skipLoadingOnRefresh
or manually turn it off in different places.Beta Was this translation helpful? Give feedback.
All reactions