Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong refactory opportunity on defmacro __using__(_) #3

Closed
hirschenberger opened this issue Nov 17, 2015 · 3 comments
Closed

Wrong refactory opportunity on defmacro __using__(_) #3

hirschenberger opened this issue Nov 17, 2015 · 3 comments

Comments

@hirschenberger
Copy link

Credo warns about too complex functions when using defmacro __using__ which is unnecessary to split up.
@rrrene
Copy link
Owner

rrrene commented Nov 17, 2015

Right, will fix for next release! 👍 Thx for reporting!

@hirschenberger
Copy link
Author

Great, very nice work btw. 👏

@rrrene rrrene closed this as completed in f7bf456 Nov 17, 2015
@rrrene
Copy link
Owner

rrrene commented Nov 17, 2015

v0.1.4 contains this fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rrrene @hirschenberger