Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistency issue bug with parenthesis spaces #38

Closed
ontofractal opened this issue Feb 10, 2016 · 6 comments
Closed

consistency issue bug with parenthesis spaces #38

ontofractal opened this issue Feb 10, 2016 · 6 comments

Comments

@ontofractal
Copy link
Contributor

Credo reports that "There are no spaces after/before parentheses, but here there are." for this line:

body = URI.encode_query %{ query: options.query }

Changing the code to this removes the consistency issue notification:

body = URI.encode_query %{query: options.query} 

Obviously, those are not parenthesis :)

@rrrene
Copy link
Owner

rrrene commented Feb 10, 2016

Aren't those curly parentheses? (sorry, not a native speaker)

The check currently looks at {}, [], and ().

@rrrene
Copy link
Owner

rrrene commented Feb 10, 2016

Ah, it's curly brackets, right?

@ontofractal
Copy link
Contributor Author

Ah, I thought that this was just a naming issue. Maybe change the recommendation to something like this?

[C] ↗ Whitespace around parentheses/brackets is not consistent with other code in the project 

@rrrene
Copy link
Owner

rrrene commented Feb 10, 2016

Perfect, will incorporate your suggestion when I get home! 👍

@ontofractal
Copy link
Contributor Author

Great, I am sending a pull request both for presence and lack of whitespace.
#39

@rrrene
Copy link
Owner

rrrene commented Feb 11, 2016

This is fixed in v0.3.1. Thanks again! 👍

@rrrene rrrene closed this as completed Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants