Ambiguous variables should probably check arity

[philipgiuliani]

Josè has changed the generators in phoenix to use struct as parameter instead of model:

def changeset(struct, params \\ %{}) do

Credo doesn't like that:

[W] ↗ Parameter `struct` has same name as the `Kernel.struct` function.

So i asked Jose about it and he told me that Kernel only implements struct/2, so it is ok to use struct/0 here.

I think it would be right that NameRedeclarationByAssignment is actually checking the exact method. So not just struct but struct/2

[rrrene]

That's a valid argument.

I am a bit uncertain whether or not to keep these checks at all. Originally you could write something like

defp server(https \\ false) do
  # ... code ...
end

# somewhere in a function:
server = server(true)

Now, with a regular call to server it might have become unclear if you were calling the variable or the function (using default arguments). But since Elixir 1.2 you would have to call server() to call the function, so this check might be outdated ...

Long story short, you're suggestion to check the arity is a very good one to solve those problems. 👍

[philipgiuliani]

Woho, awesome! :)

[rrrene]

v0.4.5 is live and contains this fix.

[net]

Yay!