Revert "fix: Exclude scripts loaded with rel=modulepreload from sna…

…pshots (#1128)" This reverts commit b540c04.
rrweb-io · Feb 14, 2023 · 1d5a5b8 · 1d5a5b8
1 parent b540c04
commit 1d5a5b8
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/packages/rrweb-snapshot/src/rebuild.ts b/packages/rrweb-snapshot/src/rebuild.ts
@@ -221,8 +221,7 @@ function buildNode(
             continue;
           } else if (
             tagName === 'link' &&
-            (n.attributes.rel === 'preload' ||
-              n.attributes.rel === 'modulepreload') &&
+            n.attributes.rel === 'preload' &&
             n.attributes.as === 'script'
           ) {
             // ignore

diff --git a/packages/rrweb-snapshot/src/snapshot.ts b/packages/rrweb-snapshot/src/snapshot.ts
@@ -813,10 +813,9 @@ function slimDOMExcluded(
       slimDOMOptions.script &&
       // script tag
       (sn.tagName === 'script' ||
-        // (module)preload link
+        // preload link
         (sn.tagName === 'link' &&
-          (sn.attributes.rel === 'preload' ||
-            sn.attributes.rel === 'modulepreload') &&
+          sn.attributes.rel === 'preload' &&
           sn.attributes.as === 'script') ||
         // prefetch link
         (sn.tagName === 'link' &&

diff --git a/packages/rrweb-snapshot/test/__snapshots__/integration.test.ts.snap b/packages/rrweb-snapshot/test/__snapshots__/integration.test.ts.snap
@@ -370,7 +370,6 @@ exports[`integration tests [html file]: preload.html 1`] = `
     <title>Document</title>
     <link />
     <link />
-    <link />
   </head>
   <body></body></html>"
 `;

diff --git a/packages/rrweb-snapshot/test/html/preload.html b/packages/rrweb-snapshot/test/html/preload.html
@@ -4,7 +4,6 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Document</title>
-    <link rel="modulepreload" href="https://example/path/to/preload.js" as="script" />
     <link rel="preload" href="https://example/path/to/preload.js" as="script" />
     <link rel="prefetch" href="https://example/path/to/prefetch.js" />
   </head>