Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Exclude scripts loaded with rel=modulepreload from snapshots #1128

Merged
merged 2 commits into from
Feb 14, 2023
Merged

fix: Exclude scripts loaded with rel=modulepreload from snapshots #1128

merged 2 commits into from
Feb 14, 2023

Conversation

billyvg
Copy link
Contributor

@billyvg billyvg commented Feb 13, 2023

We were only excluding <link rel="preload" as="script" /> but we should include rel="modulepreload" as well.

@billyvg
fix: Exclude modulepreload as well
564905d 
We were only excluding `<link rel="preload" as="script" />` but we should include `rel="modulepreload"` as well
@billyvg @github-actions
Apply formatting changes
84605b5
@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2023

⚠️ No Changeset found

Latest commit: 84605b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@billyvg billyvg changed the title fix: Exclude modulepreload from snapshots as well fix: Exclude scripts loaded with rel=modulepreload from snapshots Feb 13, 2023
Juice10
Juice10 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@Juice10 Juice10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this @billyvg

@Juice10 Juice10 merged commit b540c04 into rrweb-io:master Feb 14, 2023
Juice10 added a commit that referenced this pull request Feb 14, 2023
@Juice10
Revert "fix: Exclude scripts loaded with rel=modulepreload from sna…
1d5a5b8 
…pshots (#1128)"

This reverts commit b540c04.
@billyvg billyvg deleted the fix-exclude-modulepreload-link-v2 branch February 15, 2023 16:52
@billyvg billyvg mentioned this pull request Feb 15, 2023
Merged
This was referenced Jul 6, 2023
Closed
Closed
Closed
@billyvg billyvg mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juice10 Juice10 Juice10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@billyvg @Juice10