Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to stop recording #16

Closed
ChuckJonas opened this issue Dec 28, 2018 · 1 comment
Closed

Ability to stop recording #16

ChuckJonas opened this issue Dec 28, 2018 · 1 comment

Comments

@ChuckJonas
Copy link
Contributor

Seems like it would make sense to have the ability to stop recording.
@ChuckJonas ChuckJonas mentioned this issue Dec 29, 2018
Closed
@Yuyz0112
Copy link
Member

Yuyz0112 commented Dec 29, 2018 •
edited

Oh, my fault about missing this in the doc.

The recorder already implemented the stop method like this:

type record = (options: recordOptions) => listenerHandler;

It means the record method will return a function to you which is a stopper, you can stop recording by calling the return function.

@ChuckJonas ChuckJonas mentioned this issue Dec 29, 2018
Merged
lewgordon-amplitude pushed a commit to lewgordon-amplitude/rrweb that referenced this issue Aug 1, 2024
@jxiwang
Merge pull request rrweb-io#16 from amplitude/AMP-99342-Regex-Error
1b0c58a 
Amp 99342 regex error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChuckJonas @Yuyz0112