Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cannot set property attributeName of #<MutationRecord> which has only a getter #1173

Merged
merged 2 commits into from
Mar 15, 2023
Merged

fix: Cannot set property attributeName of #<MutationRecord> which has only a getter #1173

merged 2 commits into from
Mar 15, 2023

Conversation

wfk007
Copy link
Contributor

@wfk007 wfk007 commented Mar 10, 2023

  1. fix MutationRecord type error: Properties in MutationRecord are all ReadOnly which will throw a runtime type error
  2. fix slimDOM type error in rrweb-snapshot

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: b0d5b8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

YunFeng0817
YunFeng0817 reviewed Mar 13, 2023
View reviewed changes
packages/rrweb/src/record/mutation.ts
@@ -509,15 +509,9 @@ export default class MutationBuffer {
if (
target.tagName === 'IFRAME' &&
m.attributeName === 'src' &&
!this.keepIframeSrcFn(value as string)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other changes all look good. But what's the motivation for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other changes all look good. But what's the motivation for this change?

If the attributeName is read-only, this line seems useless, so in order to keep code and logic clean, I delete this line.
But if it is necessary to keep it, I can restore this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is important because some people may rely on this configuration. Do you know how to keep its original logic and keep mutation unchanged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is important because some people may rely on this configuration. Do you know how to keep its original logic and keep mutation unchanged?

@YunFeng0817 updated

YunFeng0817
YunFeng0817 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@YunFeng0817 YunFeng0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@YunFeng0817 YunFeng0817 merged commit 5982c89 into rrweb-io:master Mar 15, 2023
This was referenced May 21, 2023
Open
Closed
This was referenced Jul 6, 2023
Closed
Closed
Closed
@billyvg billyvg mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YunFeng0817 YunFeng0817 YunFeng0817 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wfk007 @YunFeng0817