Fix incorrect restart of playback while artificially paused #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…npause' a user pause action
|
Yep, this issue also makes the rrweb-player's auto play config unstable. The fix is nice and I'm going to merge it. And then I would like to introduce a state machine to describe the replayer's state and makes it easier to test and integrate. |
billyvg
added a commit
to p-mazhnik/rrweb
that referenced
this pull request
May 21, 2024
This brings our fork up to date with the latest upstream changes except the reverted commits in getsentry#186. `develop` branch will represent the rrweb changes that we want to use, `master` tracks upstream master, and `sentry-v2` is contains our forked changes on top of `develop`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of pause/play state so that player doesn't accidentally 'unpause' a user pause action.
I can reliably recreate the problem on a recording with stylesheets by doing:
player.on('fullsnapshot-rebuilded', player.pause);The playback sometimes pauses, but depending on the timing of how external stylesheets load, the pause may not work, and play will continue.
(Pausing on the first fullsnapshot-rebuilded is very useful in order to present user with a 'screenshot' of the first screen before starting playback)
I haven't created a test case as none of the existing testcases rely on an external stylesheet (which could introduce a delay to the tests?), let me know if it's okay (and how) to introduce such a test case.